fix: Stop sending before logs when after is specified (#2585)

kylecarbs · web-flow · commit caf9c41a9e33 · 2022-06-22T17:09:28.000Z
This fixes duplicate logs appearing in completed jos!
diff --git a/coderd/provisionerjobs.go b/coderd/provisionerjobs.go
@@ -72,7 +72,10 @@ func (api *API) provisionerJobLogs(rw http.ResponseWriter, r *http.Request, job
 		}
 		before = time.UnixMilli(beforeMS)
 	} else {
-		before = database.Now()
+		// If we're following, we don't want logs before a timestamp!
+		if !follow {
+			before = database.Now()
+		}
 	}
 
 	if !follow {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,10 @@ func (api API) provisionerJobLogs(rw http.ResponseWriter, r http.Request, job`
`72`	`72`	`}`
`73`	`73`	`before = time.UnixMilli(beforeMS)`
`74`	`74`	`} else {`
`75`		`- before = database.Now()`
	`75`	`+ // If we're following, we don't want logs before a timestamp!`
	`76`	`+ if !follow {`
	`77`	`+ before = database.Now()`
	`78`	`+ }`
`76`	`79`	`}`
`77`	`80`
`78`	`81`	`if !follow {`