Add comment

mafredri · mafredri · commit e17ad956f122 · 2023-04-06T16:42:11.000Z
diff --git a/agent/agentssh/agentssh.go b/agent/agentssh/agentssh.go
@@ -615,6 +615,9 @@ func (s *Server) Close() error {
 	// Close all active sessions to gracefully
 	// terminate client connections.
 	for ss := range s.sessions {
+		// We call Close on the underlying channel here because we don't
+		// want to send an exit status to the client (via Exit()).
+		// Typically OpenSSH clients will return 255 as the exit status.
 		_ = ss.Close()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -615,6 +615,9 @@ func (s *Server) Close() error {`
`615`	`615`	`// Close all active sessions to gracefully`
`616`	`616`	`// terminate client connections.`
`617`	`617`	`for ss := range s.sessions {`
	`618`	`+ // We call Close on the underlying channel here because we don't`
	`619`	`+ // want to send an exit status to the client (via Exit()).`
	`620`	`+ // Typically OpenSSH clients will return 255 as the exit status.`
`618`	`621`	`_ = ss.Close()`
`619`	`622`	`}`
`620`	`623`