fix: Don't fetch resources when a workspace is building (#3424)

kylecarbs · web-flow · commit e1da2b64679a · 2022-08-09T14:07:01.000Z
Fixes #3423.
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -81,6 +81,7 @@ export const MockProvisionerJob: TypesGen.ProvisionerJob = {
   id: "test-provisioner-job",
   status: "succeeded",
   storage_source: "asdf",
+  completed_at: "2022-05-17T17:39:01.382927298Z",
 }
 
 export const MockFailedProvisionerJob: TypesGen.ProvisionerJob = {
diff --git a/site/src/xServices/workspace/workspaceXService.ts b/site/src/xServices/workspace/workspaceXService.ts
@@ -550,12 +550,13 @@ export const workspaceMachine = createMachine(
         }
       },
       getResources: async (context) => {
-        if (context.workspace) {
-          const resources = await API.getWorkspaceResources(context.workspace.latest_build.id)
-          return resources
-        } else {
-          throw Error("Cannot fetch workspace resources without workspace")
+        // If the job hasn't completed, fetching resources will result
+        // in an unfriendly error for the user.
+        if (!context.workspace?.latest_build.job.completed_at) {
+          return []
         }
+        const resources = await API.getWorkspaceResources(context.workspace.latest_build.id)
+        return resources
       },
       getBuilds: async (context) => {
         if (context.workspace) {

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ export const MockProvisionerJob: TypesGen.ProvisionerJob = {`
`81`	`81`	`id: "test-provisioner-job",`
`82`	`82`	`status: "succeeded",`
`83`	`83`	`storage_source: "asdf",`
	`84`	`+ completed_at: "2022-05-17T17:39:01.382927298Z",`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`export const MockFailedProvisionerJob: TypesGen.ProvisionerJob = {`