Skip to content

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 3, 2024

#11381 made changes to coderd/database/dbfake.
Because test-go-pg got skipped, a test flake snuck onto main.
https://github.com/coder/coder/actions/runs/7395536966/job/20118913609

To prevent this from happening in future:

  • Broadening scope of needs.changes.db to include anything under the path coderd/database.
  • Removing dependency of test-go-pg on sqlc-vet.

@johnstcn johnstcn self-assigned this Jan 3, 2024
@johnstcn johnstcn requested a review from mafredri January 3, 2024 12:50
@johnstcn johnstcn enabled auto-merge (squash) January 3, 2024 12:56
@johnstcn johnstcn requested a review from Emyrk January 3, 2024 12:56
@johnstcn johnstcn disabled auto-merge January 3, 2024 12:56
@johnstcn johnstcn merged commit 4f433e7 into main Jan 4, 2024
@johnstcn johnstcn deleted the cj/github-ci-changes-db branch January 4, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy