Skip to content

feat: batch workspace updates #11583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 18, 2024
Merged

feat: batch workspace updates #11583

merged 14 commits into from
Jan 18, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 11, 2024 •
edited
Loading

Closes #11326

  • Will show a warning about updating workspaces while they're in use if any selected workspaces are running.
  • Will show a warning for any selected dormant workspaces, and ignore them.
  • Shows a summary of the updated templates, their latest update messages, and which workspaces use which template.
  • Skips selected workspaces which are already up-to-date
Screen.Recording.2024-01-16.at.4.52.31.PM.mov

@matifali
Copy link
Member

Are you checking if a workspace is already on the latest version? We should start it again in such cases.

@aslilac
Copy link
Member Author

aslilac commented Jan 16, 2024

Are you checking if a workspace is already on the latest version? We should start it again in such cases.

it now checks if they're already on the latest version, but it seems like the consensus is to leave up-to-date workspaces untouched (including stopped ones)

@aslilac aslilac marked this pull request as ready for review January 17, 2024 00:10
BrunoQuaresma
BrunoQuaresma reviewed Jan 17, 2024
View reviewed changes
BrunoQuaresma
BrunoQuaresma approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I'm wondering if we should add integration tests for all 4 scenarios you described in the PR description.

Parkreiner
Parkreiner approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this also looks good to me, too. Just had one question about a change that could make the code easier to maintain down the line, but that I don't have enough context to say is a good change or not

@aslilac
Copy link
Member Author

aslilac commented Jan 17, 2024

just need to get storybook working and this'll be ready. but the component uses useQuery 💀

@aslilac aslilac merged commit 9ed3487 into main Jan 18, 2024
@aslilac aslilac deleted the batch-update branch January 18, 2024 22:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Bulk workspace update for the Operator
4 participants
@aslilac @matifali @BrunoQuaresma @Parkreiner
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy