Skip to content

refactor(site): apply cosmetic changes and remove ExternalAuth from settings page #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2024
Merged

refactor(site): apply cosmetic changes and remove ExternalAuth from settings page #11756

merged 2 commits into from
Jan 22, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screenshot 2024-01-22 at 14 22 50

After:
Screenshot 2024-01-22 at 14 23 45

@BrunoQuaresma BrunoQuaresma requested review from a team and Parkreiner and removed request for a team January 22, 2024 17:24
@BrunoQuaresma BrunoQuaresma requested a review from Emyrk January 22, 2024 17:25
Parkreiner
Parkreiner approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of how much cleaner the code looks. I flagged the <th> changes because Axe complained when I ran an audit, but that's the only the only nick

@BrunoQuaresma BrunoQuaresma force-pushed the bq/refactor-external-auth branch from e75d064 to 40dd904 Compare January 22, 2024 18:27
@BrunoQuaresma BrunoQuaresma merged commit a31d19d into main Jan 22, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-external-auth branch January 22, 2024 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @Emyrk @Parkreiner
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy