test: Regenerate GitSSHKey flake when comparing times #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a crazy one! The in-memory DB is fast, which allows the same exact timestamp to occur for regenerating the key! See: https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82
|
Happened in #1231 |
Codecov Report
@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
+ Coverage 65.33% 65.76% +0.43%
==========================================
Files 266 272 +6
Lines 17651 17872 +221
Branches 192 192
==========================================
+ Hits 11532 11754 +222
- Misses 4880 4886 +6
+ Partials 1239 1232 -7
Continue to review full report at Codecov.
|
f0ssel
approved these changes
Apr 29, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This is a crazy one! The in-memory DB is fast, which allows the same exact timestamp to occur for regenerating the key! See: https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a crazy one! The in-memory DB is fast, which allows the same
exact timestamp to occur for regenerating the key!
See: https://github.com/coder/coder/runs/6234173911?check_suite_focus=true#step:9:82