Skip to content

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 21, 2024

Fixes: #13219

The PR implements logic to mutate template tags based on coder_parameter values.

@mtojek mtojek self-assigned this May 21, 2024
@mtojek mtojek requested review from johnstcn and mafredri May 22, 2024 13:27
@mtojek mtojek marked this pull request as ready for review May 22, 2024 13:27
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise LGTM!

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also 👍

return nil, BuildError{http.StatusBadRequest, "failed to evaluate workspace tag value", xerrors.Errorf(diags.Error())}
}

// Do not use "val.AsString()" as it can panic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@mtojek mtojek enabled auto-merge (squash) May 23, 2024 07:45
@mtojek mtojek merged commit c2837a6 into main May 23, 2024
@mtojek mtojek deleted the 13219-select-provisioner branch May 23, 2024 07:53
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coderd: select provisioners based on workspace tags
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy