chore(site): refactor filters #13394
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-template-filter
…-template-filter
Parkreiner
reviewed
May 30, 2024
There was a problem hiding this comment.
I like this new approach a lot! Had a couple of suggestions here and there, but I think the core logic looks really nice
It looks like this isn't fully done yet (some components not being integrated, some debugger statements still being in the code), but let me know when you want me to do another review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to refactor our filters to make them easier to maintain. The current abstraction is not ideal. I'm opening this PR to collect early feedback.
Related to #13035