Skip to content

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 6, 2024

Fixes #13489

  • Removed the check for a healthy node report. At this stage, we're not interested in whether the report is healthy or not, but that it contains the correct number of node reports.
  • In derphealth, we hard-code a 10-second deadline when running a NodeReport. Modified to only set a deadline if none is already set on the parent context.

@johnstcn johnstcn merged commit 48ecee1 into main Jun 7, 2024
@johnstcn johnstcn deleted the cj/flake/cli-healthcheck branch June 7, 2024 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestNetcheck: timeout reading from 127.0.0.1
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy