chore: remove org context switcher in the cli #13674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0e9124 to
2917474
Compare
aslilac
reviewed
Jun 28, 2024
cli/root.go
Outdated
| // Otherwise, we can assume a default value. | ||
| Required: false, | ||
| Flag: "org", | ||
| FlagShorthand: "z", |
There was a problem hiding this comment.
-z is a really weird choice here imo. I know -o is used, but what about -O? just doesn't feel like there is very clear connection.
There was a problem hiding this comment.
I was thinking organiZation lol. I can switch to -O
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Removes the cli organization switcher. All commands that require an organization context default to an organization if the user is only in 1 org. Multi org users require setting
CODER_ORGANIZATION=<org>or--org=<organization>(-O=<organization>shorthand)Future Work
Ideally we could remove the organization context required from many of the template related commands if the template name is unambiguous. At present, the organization ID is required for the fetching template API.