Skip to content

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jul 23, 2024

*.tfvars files in template version tarballs are currently ignored by coderd.
#11549 fixed this by having the CLI parse those files from the template directory before uploading.
This PR enables the creation of templates with these *.tfvars files using just codersdk.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson requested a review from mtojek July 23, 2024 12:23
@ethanndickson ethanndickson marked this pull request as ready for review July 23, 2024 12:24
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as long as CI does not complain.

@ethanndickson ethanndickson merged commit 7028ff7 into main Jul 24, 2024
39 checks passed
@ethanndickson ethanndickson deleted the 07-23-feat_codersdk_export_template_variable_parser branch July 24, 2024 04:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy