fix: avoid deleting peers on graceful close #14165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sreya
commented
Aug 5, 2024
- Fixes an issue where a coordinator deletes all its peers on shutdown. This can cause disconnects whenever a coderd is redeployed.
- Fixes an issue where a coordinator deletes all its peers on shutdown. This can cause disconnects whenever a coderd is redeployed.
spikecurtis
reviewed
Aug 6, 2024
There was a problem hiding this comment.
I added a bunch of stuff in #12155 to ensure that the binder and tunneler complete before the querier closes, since that would delete the Coordinator row from the DB. Now that we aren't deleting that row, the ordering isn't necessary, and there are comments I added that are no longer true.
I think we should keep the tracking of when things shut down, though, so that Close() doesn't return while there are still PGCoordinator goroutines running.
sreya
commented
Aug 12, 2024
spikecurtis
reviewed
Aug 12, 2024
spikecurtis
approved these changes
Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.