chore: revert status code change for delete users endpoint #14168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreya
approved these changes
Aug 5, 2024
aslilac
reviewed
Aug 5, 2024
| @@ -309,7 +309,7 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error { | |||
| return err | |||
| } | |||
| defer res.Body.Close() | |||
| if res.StatusCode != http.StatusNoContent { | |||
There was a problem hiding this comment.
did a version get released with the other status code? should this be res.StatusCode != http.StatusNoContent && res.StatusCode != http.StatusOK?
There was a problem hiding this comment.
you are right. I didn't think about that when I reverted. Let me throw up another 🤦
aslilac
reviewed
Aug 5, 2024
| @@ -513,7 +513,7 @@ func (api *API) postUser(rw http.ResponseWriter, r *http.Request) { | |||
| // @Security CoderSessionToken | |||
| // @Tags Users | |||
| // @Param user path string true "User ID, name, or me" | |||
| // @Success 204 | |||
| // @Success 200 | |||
There was a problem hiding this comment.
also this should probably specify codersdk.Response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert from #13870