feat(coderd): add workspace timings endpoint #14648
Conversation
Co-authored-by: Aaron Lehmann <alehmann@netflix.com>
…oner-timings-endpoint
…coder/coder into bq/provisioner-timings-endpoint
There was a problem hiding this comment.
Great work @BrunoQuaresma!
One minor suggestion but otherwise 👌
| @@ -1791,6 +1791,10 @@ func (q *querier) GetProvisionerJobByID(ctx context.Context, id uuid.UUID) (data | |||
| return job, nil | |||
| } | |||
|
|
|||
| func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) { | |||
| return q.db.GetProvisionerJobTimingsByJobID(ctx, jobID) | |||
There was a problem hiding this comment.
@BrunoQuaresma I missed this yesterday; we need to ensure the user can read the workspace build in order to read the timings, otherwise we might leak some information.
There was a problem hiding this comment.
I don't see any RBAC resource related to the workspace build. The closest that I see is the rbac.ResourceWorkspace, does it work?
There was a problem hiding this comment.
I think you can take a look at GetProvisionerLogsAfterID. As you can see, it is assumed that if you can fetch Job from the database, you can also read Logs
There was a problem hiding this comment.
@mtojek even better, ty
|
Closes coder/internal#43 |
Related to coder/internal#44