Skip to content

chore: add scim service provider config endpoint #15235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

chore: add scim service provider config endpoint #15235

merged 4 commits into from
Oct 25, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Oct 25, 2024 •
edited
Loading

What this does

Adds a static /scim/v2/ServiceProviderConfig endpoint. Our scim support is static, so the response config is also defined statically.

This endpoint just indicates what level of SCIM support Coder has.

References

Examples

This is a v1 example

curl http://localhost:3000/scim/v2curl --request GET \                                                                                         11:23:47 AM
     --url https://api.oneflow.com/scim/v1/ServiceProviderConfig \
     --header 'accept: application/scim+json'

A v2 example:
https://developer.4me.com/v1/scim/service_provider_config/

PR Example response

{
  "schemas": [
    "urn:ietf:params:scim:schemas:core:2.0:ServiceProviderConfig"
  ],
  "documentationUri": "https://coder.com/docs/admin/users/oidc-auth#scim-enterprise-premium",
  "patch": {
    "supported": true
  },
  "bulk": {
    "supported": false,
    "maxOperations": 0,
    "maxPayloadSize": 0
  },
  "filter": {
    "supported": false,
    "maxResults": 0
  },
  "changePassword": {
    "supported": false
  },
  "sort": {
    "supported": false
  },
  "etag": {
    "supported": false
  },
  "authenticationSchemes": [
    {
      "type": "oauthbearertoken",
      "name": "HTTP Header Authentication",
      "description": "Authentication scheme using the Authorization header with the shared token",
      "specUri": "",
      "documentationUri": "https://coder.com/docs/admin/users/oidc-auth#scim-enterprise-premium"
    }
  ],
  "meta": {
    "created": "2024-10-25T17:00:00Z",
    "lastModified": "2024-10-25T17:00:00Z",
    "location": "https://270li0flnlroo.pit-1.try.coder.app/scim/v2/ServiceProviderConfig",
    "resourceType": "ServiceProviderConfig"
  }
}

@Emyrk Emyrk marked this pull request as ready for review October 25, 2024 18:50
@Emyrk Emyrk requested a review from coadler October 25, 2024 18:52
coadler
coadler approved these changes Oct 25, 2024
View reviewed changes
enterprise/coderd/scim.go
Comment on lines +47 to +49
// @Summary SCIM 2.0: Service Provider Config
// @ID scim-get-service-provider-config
// @Produce application/scim+json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to use this now

Suggested change
// @Summary SCIM 2.0: Service Provider Config
// @ID scim-get-service-provider-config
// @Produce application/scim+json
// @Summary SCIM 2.0: Service Provider Config
// @ID scim-get-service-provider-config
// @Security Authorization
// @Produce application/scim+json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait I'm stupid, disregard

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup no auth for this endpoint 👍

@Emyrk Emyrk merged commit e03ef62 into main Oct 25, 2024
39 checks passed
@Emyrk Emyrk deleted the stevenmasley/scim_provider_config branch October 25, 2024 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @coadler
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy