Skip to content

Conversation

dannykopping
Copy link
Contributor

The current description of "Configure your notification preferences. Icons on the right of each notification indicate delivery method, either SMTP or Webhook." doesn't really say what this page is for.

I've adjusted the wording, and also changed the tooltip of the delivery method icon to be more clear.

…tifications can be disabled

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping changed the title chore(notifications): clarify section description to indicate that notifications can be disabled chore: clarify section description to indicate that notifications can be disabled Nov 5, 2024
@dannykopping dannykopping requested a review from chrifro November 5, 2024 14:35
Copy link

@chrifro chrifro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dannykopping
Copy link
Contributor Author

@chrifro thanks for the review; will you approve the UI tests, or shall I?

@dannykopping dannykopping merged commit cafb963 into main Nov 6, 2024
31 checks passed
@dannykopping dannykopping deleted the dk/not-settings-fix branch November 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy