feat(provisioner): add support for workspace_owner_login_type #15499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
Nov 13, 2024
johnstcn
commented
Nov 13, 2024
johnstcn
commented
Nov 13, 2024
| @@ -703,13 +705,57 @@ func TestProvision(t *testing.T) { | |||
| }}, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "workspace-owner-login-type", | |||
| SkipReason: "field will be added in provider version 1.1.0", | |||
There was a problem hiding this comment.
note: I'm getting the ducks in a row now so that when the provider is released we can lock this in
There was a problem hiding this comment.
Nit: I wonder if we could expand this to be more strictly version-dependent?
For example, the tests could have a defined version under which they work and if that version does not exist then the test can be skipped.
There was a problem hiding this comment.
That would be wonderful to have!
dannykopping
approved these changes
Nov 13, 2024
| @@ -703,13 +705,57 @@ func TestProvision(t *testing.T) { | |||
| }}, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "workspace-owner-login-type", | |||
| SkipReason: "field will be added in provider version 1.1.0", | |||
There was a problem hiding this comment.
Nit: I wonder if we could expand this to be more strictly version-dependent?
For example, the tests could have a defined version under which they work and if that version does not exist then the test can be skipped.
mtojek
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coder/terraform-provider-coder#235
Adds support for the
coder_workspace_owner.login_typeattribute.(Note: need to cherry-pick coder/terraform-provider-coder#287 and do a release)