Skip to content

Conversation

matifali
Copy link
Member

@matifali matifali commented Dec 9, 2024

A workaround for #15557. We will come up with a more permanent solution

Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifali matifali enabled auto-merge (squash) December 9, 2024 09:16
@matifali matifali disabled auto-merge December 9, 2024 09:18
@matifali
Copy link
Member Author

matifali commented Dec 9, 2024

@deansheather looks like matrix context is not available at job level.

[Invalid workflow file: .github/workflows/ci.yaml#L644](https://github.com/coder/coder/actions/runs/12232484795/workflow)
The workflow is not valid. .github/workflows/ci.yaml (Line: 644, Col: 9): Unrecognized named-value: 'matrix'. Located at position 198 within expression: (needs.changes.outputs.go == 'true' || needs.changes.outputs.ts == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main') && !(github.event.pull_request.head.repo.fork && matrix.variant.premium)

We can either move the condition to all individual steps or skip both e2e and e2e-premium tests.

@deansheather
Copy link
Member

@matifali maybe just make it skip e2e entirely for now to unblock external contributions, and we can prioritise coming up with a solution (like generating short licenses each time)

@matifali matifali changed the title ci: skip running test-e2e-premium on PRs from forks ci: skip running test-e2e on PRs from forks Dec 9, 2024
@matifali matifali enabled auto-merge (squash) December 9, 2024 09:45
@matifali matifali merged commit 901ad3f into main Dec 9, 2024
33 checks passed
@matifali matifali deleted the atif/skip-e2e-premium-forks branch December 9, 2024 09:50
aslilac pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Dean Sheather <dean@deansheather.com>
@matifali matifali linked an issue Jan 3, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forks are unable to run ci because no access to secrets
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy