chore: add spinner component #16014
Merged
chore: add spinner component #16014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma Im curious why not just use the Radix spinner component directly? For example, the Radix spinner has a bit of a better style because of the thicker lines and matches the Figma design a bit better. |
jaaydenh
reviewed
Jan 2, 2025
Because it’s not a primitive—we’d have to install the entire Radix UI package along with their setup. |
Co-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
…oder into bq/add-spinner-component
jaaydenh
reviewed
Jan 2, 2025
Co-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
…oder into bq/add-spinner-component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is necessary to move forward with the "Define a global button style" issue, as it requires buttons to support loading states with spinners. The
Spinnercomponent is heavily inspired by the Radix UI Spinner component and was developed with the help of v0.Preview
