Skip to content

fix: display all available settings #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: display all available settings #16798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7590fb8
fix: display all available settings
mtojek Mar 4, 2025
27fce3b
one more time
mtojek Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions site/src/pages/DeploymentSettingsPage/OptionsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,6 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {
</TableHead>
<TableBody>
{Object.values(options).map((option) => {
if (
option.value === null ||
option.value === "" ||
option.value === undefined
) {
return null;
}
return (
<TableRow key={option.flag} className={`option-${option.flag}`}>
<TableCell>
Expand Down
5 changes: 4 additions & 1 deletion site/src/pages/DeploymentSettingsPage/optionValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ export function optionValue(
break;
}

if (!option.value) {
return "";
}

// We show all experiments (including unsafe) that are currently enabled on a deployment
// but only show safe experiments that are not.
// biome-ignore lint/suspicious/noExplicitAny: opt.value is any
Expand All @@ -59,7 +63,6 @@ export function optionValue(
experimentMap[v] = true;
}
}

return experimentMap;
}
default:
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy