Skip to content

chore(cli): increase healthcheck timeout in TestSupportbundle #17291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

chore(cli): increase healthcheck timeout in TestSupportbundle #17291

merged 5 commits into from
Apr 9, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Apr 8, 2025

Fixes coder/internal#272

  • Increases healthcheck timeout in tests. This seems to be the most usual cause of test failures.
  • Adds a non-nilness check before caching a healthcheck report.
  • Modifies the HTTP response code to 503 (was 404) when no healthcheck report is available. 503 seems to be a better indicator of the server state in this case, whereas 404 could be misinterpreted as a typo in the healthcheck URL.

@johnstcn johnstcn self-assigned this Apr 8, 2025
@johnstcn johnstcn changed the title chore(cli): TestSupportbundle: fix test flakes chore(cli): increase healthcheck timeout in TestSupportbundle Apr 8, 2025
ethanndickson
ethanndickson reviewed Apr 8, 2025
View reviewed changes
@johnstcn johnstcn merged commit a8fbe71 into main Apr 9, 2025
29 checks passed
@johnstcn johnstcn deleted the cj/flake/cli/support/NoAgent branch April 9, 2025 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestSupportBundle/NoWorkspace: health report should not be empty
2 participants
@johnstcn @ethanndickson
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy