Skip to content

chore: mark parameters as required #17551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

chore: mark parameters as required #17551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
644795c
chore: mark parameters as required
jaaydenh Apr 23, 2025
8c7d3a9
fix: fix format
jaaydenh Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,12 @@ const ParameterLabel: FC<ParameterLabelProps> = ({ parameter, isPreset }) => {

<div className="flex flex-col w-full gap-1">
<Label className="flex gap-2 flex-wrap text-sm font-medium">
{displayName}

<span className="flex">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I decided to add the required asterisk for all parameters even though it really doesn't make sense for (checkbox, slider, radio, switch) since all parameters have the required prop.

{displayName}
{!parameter.required && (
<span className="text-content-destructive">*</span>
)}
</span>
{parameter.mutable && (
<TooltipProvider delayDuration={100}>
<Tooltip>
Expand Down Expand Up @@ -169,6 +173,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
onValueChange={onChange}
defaultValue={defaultValue}
disabled={disabled}
required={parameter.required}
>
<SelectTrigger>
<SelectValue
Expand Down Expand Up @@ -325,6 +330,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
placeholder={
(parameter.styling as { placeholder?: string })?.placeholder
}
required={parameter.required}
/>
);

Expand All @@ -351,6 +357,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
defaultValue={defaultValue}
onChange={(e) => onChange(e.target.value)}
disabled={disabled}
required={parameter.required}
placeholder={
(parameter.styling as { placeholder?: string })?.placeholder
}
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy