chore: simplify workspaces data fetching #17703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcpeinhardt
approved these changes
May 7, 2025
| @@ -17,102 +20,99 @@ import { usePopover } from "components/deprecated/Popover/Popover"; | |||
| import { linkToTemplate, useLinks } from "modules/navigation"; | |||
| import type { FC } from "react"; | |||
| import { useQuery } from "react-query"; | |||
|
|
|||
| const Language = { | |||
There was a problem hiding this comment.
I kinda like the pattern of putting all the language in a constant but it truly doesn't matter haha.
| latestVersionId: string; | ||
| onUpdateVersion: () => void; | ||
| ariaLabel?: string; | ||
| workspace: Workspace; |
| limit: 0, | ||
| q: `template:${template.name}`, | ||
| }); | ||
| const { data } = useQuery( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using an abstraction that was not necessary to fetch workspaces data. I also took sometime to use the new useWorkspaceUpdate hook in the update workspace tooltip that was missing some important steps like confirmation.