fix: remove duplicated envbuilder vars #18144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
johnstcn
reviewed
Jun 2, 2025
There was a problem hiding this comment.
I found that this breaks non-cached usage of the template:
2025-06-02 10:47:17.530 [warn] Sending logs via AgentAPI v2 coder_version=v2.22.1+8708d81
envbuilder v1.1.0+a3a6a83 - Build development environments from repositories in a container
No Dockerfile specified, looking for a devcontainer.json...
Failed to locate devcontainer.json: open /workspaces/empty/.devcontainer: no such file or directory
Falling back to the default image...
We need to ensure that ENVBUILDER_GIT_URL gets passed to the container if var.cache_repo is empty.
johnstcn
approved these changes
Jun 3, 2025
|
/cherry-pick release/2.23 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18137
the
localsblock in thekubernetes-devcontainertemplate contains duplicated environment variables which are already present in theenvbuilder_cached_imageresource.