feat: migrate Alert component from MUI to shadcn #18412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace MUI Alert with shadcn-based implementation using class-variance-authority - Maintain backward compatibility with existing Alert API (severity, dismissible, actions, onDismiss) - Update AlertTitle imports across codebase to use new implementation - Add proper Tailwind CSS styling with dark mode support - Preserve accessibility features and smooth animations - Support all existing severity levels: info, success, warning, error Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
|
I definitely want to see this happen, but even just looking at the first few stories I see a number of things that aren't quite right. not sure how to get blink to fix any of this without eyes. |
|
@aslilac sorry about the noise, my intention was only to reopen this and test out coder tasks on cleaning it up. I didn't explicitly set it ready for review or request your review. I wonder if that could have happened automatically somehow or if Claude (through coder tasks) was able to do that itself. Maybe it has something to do with you being a codeowner? |
|
yeah, I think CODEOWNERs only kicks in when you mark it as ready. no worries tho, just lmk when you'd like a review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Alert component from MUI to shadcn implementation while maintaining full backward compatibility with the existing API.
Changes
Core Alert Component
class-variance-authorityseverity(info, success, warning, error)dismissiblefor showing dismiss buttonactionsfor custom action buttonsonDismisscallbackrole=\"alert\"Updated Imports
Updated 6 files that were importing
AlertTitlefrom MUI to use our new implementation:ChangeWorkspaceVersionDialog.tsxProvisionerAlert.tsxGitDeviceAuth.tsxOverviewPageView.tsxWorkspace.tsxSetupPageView.tsxBenefits
Test Plan