Skip to content

chore: update VPN proto to match additional types used by Coder Desktop #18504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 24, 2025
Merged

chore: update VPN proto to match additional types used by Coder Desktop #18504

merged 4 commits into from
Jun 24, 2025

Conversation

ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Jun 23, 2025 •
edited
Loading

Extends vpn.proto with DownloadProgress messages used by Coder Desktop on Windows.

@ibetitsmike ibetitsmike changed the title chore: updated VPN proto to match additional types used by Coder Desk… chore: updated VPN proto to match additional types used by Coder Desktop Jun 23, 2025
@ibetitsmike ibetitsmike changed the title chore: updated VPN proto to match additional types used by Coder Desktop chore: update VPN proto to match additional types used by Coder Desktop Jun 23, 2025
@ibetitsmike ibetitsmike enabled auto-merge (squash) June 23, 2025 15:12
johnstcn
johnstcn reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is also going out in VPN RPC version 1.2?
We should also mention it in version.go.

@ibetitsmike ibetitsmike disabled auto-merge June 23, 2025 15:19
@ibetitsmike
Copy link
Contributor Author

@johnstcn this field is already being used, but is windows specific and doesn't concern coderd, because only the vpn service and coder desktop use it. It's just hygiene to keep coder/coder a source of truth for the proto structure.
@spikecurtis approved this one in coder-desktop-windows: https://github.com/coder/coder-desktop-windows/blob/main/Vpn.Proto/vpn.proto

@johnstcn
Copy link
Member

@johnstcn this field is already being used, but is windows specific and doesn't concern coderd, because only the vpn service and coder desktop use it. It's just hygiene to keep coder/coder a source of truth for the proto structure. @spikecurtis approved this one in coder-desktop-windows: https://github.com/coder/coder-desktop-windows/blob/main/Vpn.Proto/vpn.proto

OK, in that case it might be good to have additional context in the field comments and maybe a link?

@ibetitsmike ibetitsmike enabled auto-merge (squash) June 24, 2025 10:10
@ibetitsmike ibetitsmike merged commit b091b99 into main Jun 24, 2025
29 checks passed
@ibetitsmike ibetitsmike deleted the mike/sync-vpn-tunnel-proto-with-windows branch June 24, 2025 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@spikecurtis spikecurtis spikecurtis approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@ibetitsmike ibetitsmike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibetitsmike @johnstcn @spikecurtis @deansheather
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy