fix(e2e): fix invalid Playwright selector syntax #19073
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several potential sources of flakiness in the createWorkspace e2e tests: 1. Enhanced disableDynamicParameters function: - Use networkidle instead of domcontentloaded for better page loading - Add explicit waits for form and checkbox visibility - Use more robust selectors for success messages - Add timeout buffers for UI state changes 2. Improved createWorkspace function: - Use networkidle for more reliable page loading - Add form readiness check before filling parameters - Add timeout buffer for form element rendering 3. Enhanced fillParameters function: - Add explicit timeout to parameter field selectors These changes should significantly reduce test flakiness by ensuring all UI elements are fully loaded and stable before interaction.
The selector '[role=\'alert\'], .MuiAlert-root, text=Template updated successfully' was invalid because it mixed CSS selectors with text selectors using commas. Fixed by using page.locator() with :has-text() pseudo-selectors which is the proper Playwright syntax for combining CSS selectors with text matching. Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Apply Biome formatter to fix indentation and formatting issues. Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The e2e tests were failing with this error:
The selector was invalid because it mixed CSS selectors with text selectors using commas, which is not valid Playwright syntax.
Solution
Fixed by using
page.locator()with:has-text()pseudo-selectors, which is the proper Playwright syntax for combining CSS selectors with text matching:This change:
locator()+waitFor()instead ofwaitForSelector()):has-text()Testing
The fix resolves the syntax error that was causing e2e test failures.