-
Notifications
You must be signed in to change notification settings - Fork 956
chore: correct template API docs #19228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Checked through the Swagger Editor by using "Load URL" with https://raw.githubusercontent.com/coder/coder/refs/heads/phorcys420/fix-template-api-docs/coderd/apidoc/swagger.json and it seems to be okay ![]() |
Co-authored-by: Dean Sheather <dean@deansheather.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a sound-ness perspective. I think Atif or Ben should sign off on the route name change, though
codersdk.UpdateTemplateMeta
type, because it seemed like the most appropriate type fromcodersdk/templates.go
, I made that decision based on howpatchOrganization
inenterprise/coderd/organizations.go
coder/enterprise/coderd/organizations.go
Line 28 in 2851d9f
codersdk.UpdateOrganizationRequest
body
required in the docs even though it isn't actually enforced (i.e an empty body works on that endpoint), I don't know if we should enforce it