Skip to content

chore: correct template API docs #19228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

phorcys420
Copy link
Member

@phorcys420 phorcys420 commented Aug 7, 2025

  • I used the codersdk.UpdateTemplateMeta type, because it seemed like the most appropriate type from codersdk/templates.go, I made that decision based on how patchOrganization in enterprise/coderd/organizations.go
    // @Param request body codersdk.UpdateOrganizationRequest true "Patch organization request"
    uses codersdk.UpdateOrganizationRequest
  • I made the body required in the docs even though it isn't actually enforced (i.e an empty body works on that endpoint), I don't know if we should enforce it
  • I have renamed "metadata" to "settings" so that it is more coherent with the wording in the UI, but that creates additionnal inconsistencies in logging and internal IDs that should probably be fixed at some point to make debugging easier.

@phorcys420 phorcys420 marked this pull request as draft August 7, 2025 12:18
@phorcys420 phorcys420 requested a review from deansheather August 7, 2025 14:34
@phorcys420
Copy link
Member Author

phorcys420 commented Aug 7, 2025

phorcys420 and others added 2 commits August 7, 2025 16:36
Co-authored-by: Dean Sheather <dean@deansheather.com>
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a sound-ness perspective. I think Atif or Ben should sign off on the route name change, though

@phorcys420 phorcys420 requested review from matifali and bpmct August 7, 2025 14:42
@phorcys420
Copy link
Member Author

phorcys420 commented Aug 7, 2025

fyi Atif/Ben, I have renamed the "template metadata" wording to "template settings" in API docs as that is the wording we use in the UI, and one of my customers was confused about this, we just want your opinion on this.
image

@phorcys420 phorcys420 marked this pull request as ready for review August 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy