chore: rename service -> coder_service, remove agent_id label
#19241
+40
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service -> coder_service, remove agent_id label
Emyrk
commented
Aug 7, 2025
coderd/coderd.go
Outdated
| r.Group(func(r chi.Router) { | ||
| r.Use( | ||
| // Override the request_type for agent rpc traffic. | ||
| httpmw.WithStaticProfilingLabels(pprof.Labels("request_type", "agent_rpc")), |
There was a problem hiding this comment.
This was pprof'd before, so doing this has the agent stuff in it's own group still.
Emyrk
commented
Aug 7, 2025
Comment on lines
+20
to
+28
| ServiceTag = "coder_service" | ||
|
|
||
| ServiceHTTPServer = "http-api" | ||
| ServiceLifecycles = "lifecycle-executor" | ||
| ServiceMetricCollector = "metrics-collector" | ||
| ServicePrebuildReconciler = "prebuilds-reconciler" | ||
| ServiceTerraformProvisioner = "terraform-provisioner" | ||
|
|
||
| RequestTypeTag = "coder_request_type" |
There was a problem hiding this comment.
Prefixing these tags with coder_ to prevent collisions. I think this was causing issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyroscope uses
servicetag for top level distinction. So move ourservice->coder_serviceAlso remove
pproflabels per agent id. This resulted in high cardinality with a new label for each agent.