fix: disallow lifecycle endpoints for prebuilt workspaces #19264
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssncferreira
commented
Aug 8, 2025
| // Prebuild lifecycle is managed by the reconciliation loop, with scheduling behavior | ||
| // defined per preset at the template level, not per workspace. | ||
| if workspace.IsPrebuild() { | ||
| httpapi.Write(ctx, rw, http.StatusConflict, codersdk.Response{ |
There was a problem hiding this comment.
409 Conflict based on discussion: #19252 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the API to prevent lifecycle configuration endpoints from being used on prebuilt workspaces. Since prebuilds are managed by the reconciliation loop and do not participate in the regular workspace lifecycle, they must not support per-workspace overrides for fields like deadline, TTL, autostart, or dormancy.
Attempting to use these endpoints on a prebuilt workspace will now return a clear validation error (
409 Conflict) with an appropriate explanation. This prevents accidental misconfiguration and preserves the lifecycle separation between prebuilds and regular workspaces.Changes
The following endpoints now return an error if the target workspace is a prebuild:
PUT /workspaces/{workspace}/extendPUT /workspaces/{workspace}/ttlPUT /workspaces/{workspace}/autostartPUT /workspaces/{workspace}/dormantRelated with: