fix: fix jetbrains toolbox connection tracking #19348
Conversation
|
@f0ssel, have we tested it with both the gateway and the Toolbox? The primary customer affected is still using Gateway. |
|
I was not aware it was also a gateway issue, will continue testing |
|
Yes this is a general tracking issue with JetBrains remote development. Many of the customers are still trialing the Toolbox and are still on Gateway. Unfortunately we need to support both until the gateway is sunsetted. |
|
I've added it to detect the new gateway process pattern as well, here's the example I observed in the workspace |
|
Great. Thank @f0ssel |
| @@ -46,6 +46,8 @@ const ( | |||
| // MagicProcessCmdlineJetBrains is a string in a process's command line that | |||
| // uniquely identifies it as JetBrains software. | |||
| MagicProcessCmdlineJetBrains = "idea.vendor.name=JetBrains" | |||
There was a problem hiding this comment.
Should we remove this as it isn't valid anymore?
There was a problem hiding this comment.
I'm going to leave it just for now for compatibility. This code is "legacy" is some ways anyways.
Fixes #18350
Here's the process name I used to decide what to detect:
I attempted the route of relying on just the session env vars, in hopes that this issue was fixed in Toolbox and the process name matching was no longer need, but it was not a fruitful endeavor and it seems to be using the same connection logic as it did in gateway, just with new binary and flag names.