chore: fix storybook flakes #19366
chore: fix storybook flakes #19366
Conversation
|
taking a look now |
| data: Array.from({ length: 30 }).map((_, i) => { | ||
| const date = new Date(2024, 0, i + 1); | ||
| return { | ||
| date: date.toISOString().split("T")[0], | ||
| amount: 5 + Math.floor(Math.random() * 15), | ||
| }; | ||
| }), |
There was a problem hiding this comment.
thank you for just unrolling this loop. 😄 this implementation was clever but is far less understandable at a glance, despite being like 1/3rd the lines of code.
| @@ -6,6 +7,9 @@ import { | |||
| } from "unique-names-generator"; | |||
|
|
|||
| export const generateWorkspaceName = () => { | |||
| if (isChromatic()) { | |||
| return "chromatic-workspace"; | |||
There was a problem hiding this comment.
I like the idea of just returning a constant here, but could it still be one of our actual random names just for fun?
I just got "yellow-bird-23" as a suggestion which is pretty cute 😌
| reactRouterParameters, | ||
| } from "storybook-addon-remix-react-router"; | ||
| import { WorkspaceSettingsLayout } from "../WorkspaceSettingsLayout"; | ||
| import WorkspaceSchedulePage from "./WorkspaceSchedulePage"; | ||
|
|
||
| const meta = { | ||
| title: "pages/WorkspaceSchedulePage", | ||
| component: WorkspaceSchedulePage, | ||
| component: WorkspaceSettingsLayout, |
There was a problem hiding this comment.
I'd prefer that this component stay "correct", but the way the react-router storybook addon works really confuses me, so I don't really have a better idea.
There was a problem hiding this comment.
Me too. The issue was, when using the nested layout function, the react-router decorator was load before any other local decorators, because of how we set it in the preview config, injecting the workspace settings layout before the dashboard provider that is required to make the it work.
IMO, we should simplify the global decorators and let the stories define what they want to use. Improving performance and make easier to identify the story dependencies.
Close #19365