fix: stop reading closed channel for /watch devcontainers endpoint
#19373
Conversation
Fixes #19372 We increase the read limit to 4MiB (we use this limit elsewhere). We also make sure to stop sending messages of `containersCh` becomes closed.
I've added a test in 0ca20dc If you remove the fix in |
We already do but as a coder/codersdk/wsjson/decoder.go Line 41 in 0ca20dc |
Ah nice, so we can check for |
| @@ -411,6 +412,8 @@ func (c *AgentConn) WatchContainers(ctx context.Context, logger slog.Logger) (<- | |||
| defer res.Body.Close() | |||
| } | |||
|
|
|||
| conn.SetReadLimit(1 << 22) // 4MiB | |||
There was a problem hiding this comment.
Nit: let's add a comment for this, as well as the compression, for posterity.
Re: compression, we might say that we chose nocontexttakeover to improve bandwidth cost/latency with minimal cpu/memory overhead even if contexttakeover has better compression.
Fixes #19372
We increase the read limit to 4MiB (we use this limit elsewhere). We also make sure to stop sending messages of
containersChbecomes closed.