fix: avoid error when AI usage is zero #19388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that prevents the managed AI agent usage from showing in the licenses page of the dashboard when the usage is zero.
ibetitsmike
reviewed
Aug 18, 2025
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Outdated
Show resolved
Hide resolved
ibetitsmike
approved these changes
Aug 18, 2025
aslilac
reviewed
Aug 18, 2025
Comment on lines
41
to
43
| const usage = managedAgentFeature.actual ?? 0; | ||
| const included = managedAgentFeature.soft_limit ?? 0; | ||
| const limit = managedAgentFeature.limit ?? 0; |
There was a problem hiding this comment.
not coercing these to 0 was intentional. if we get past the enabled check then these need to be some positive integer. (except usage, which can also be 0)
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that prevents the managed AI agent usage from showing in the licenses page of the dashboard when the usage is zero. Adds a story with this case as well.
!usageis true whenusage == 0.