fix: increase timeout for watch workspace agent devcontainers test #19390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes coder/internal#907 When running in a CI environment, the process of setting up the agent + coderd + creating the websocket connection can sometimes take up to 10 seconds, by which time we timeout. To resolve this we up the timeout from `WaitShort` to `WaitLong`. fix: run the formatter fix: WaitSuperLong for watch containers PayloadTooLarge test The test can take around 10s when it is the only one running, so in a constrained environment like CI it makes sense that it still hits the 25 second timeout. For now we up the limit to 60 seconds until the test is rewritten to greatly reduce the time taken.
johnstcn
approved these changes
Aug 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#907
The test can take around 10s when it is the only one running, so in a constrained environment like CI it makes sense that it still hits the 25 second timeout. For now we up the limit to 60 seconds until the test is rewritten to greatly reduce the time taken.