chore: improve scroll behavior of DashboardLayout wrapped pages #19396
+33
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
lgtm! this is a precarious enough change I'd like to get a second pair of eyes on it tho, maybe @Parkreiner?
|
Agreed, and if someone has time to pull this down and check it out locally I'd appreciate it too. A weak point of our storybook setup is we don't really test for scrolling content as often as we should |
|
I ran it locally and didn't notice any jank, I'm just paranoid lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the the
DashboardLayoutto create a singular scroll area between the top nav bar and the deployment banner on the bottom. Also improves the scroll behavior of the org settings pages.CleanShot.2025-08-18.at.13.49.29.mp4