Skip to content

fix: fix flakes in TestWorkspaceAutobuild due to incorrect tick time #19398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025

Conversation

cstyan
Copy link
Contributor

@cstyan cstyan commented Aug 18, 2025

cc @deansheather we missed these in the previous PR, we find tickTime2 and pass it to the tickCh, but we were incorrectly passing tickTime to UpdateProvisionerLastSeenAt in some places

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan cstyan changed the title fix: TestWorkspaceAutobuild flakes due to incorrect tick time fix: deal with flakes in TestWorkspaceAutobuild due to incorrect tick time Aug 18, 2025
@cstyan cstyan changed the title fix: deal with flakes in TestWorkspaceAutobuild due to incorrect tick time fix: fix flakes in TestWorkspaceAutobuild due to incorrect tick time Aug 18, 2025
@cstyan cstyan merged commit 9e5c83a into main Aug 19, 2025
37 checks passed
@cstyan cstyan deleted the callum-autobuild-flake branch August 19, 2025 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy