feat: show workspace health error alert above agents in WorkspacePage #19400
Conversation
| @@ -192,6 +196,41 @@ export const Workspace: FC<WorkspaceProps> = ({ | |||
| </Alert> | |||
| )} | |||
|
|
|||
| {!workspace.health.healthy && ( | |||
| <Alert severity="warning"> | |||
There was a problem hiding this comment.
Alert's background color is --surface-secondary. The buttons turn --surface-secondary on hover, so there's no apparent change when hovering. (This is also the case in WorkspaceNotifications.)
Does it make sense to keep these colors? Or should we do something like give NotificationActionButton an even lighter background (--surface-tertiary) on hover?
There was a problem hiding this comment.
the existing popup has the same problem. it should definitely get fixed eventually but our colors are a bit of a mess right now. probably out of scope for this issue.
There was a problem hiding this comment.
while you're poking at this, could I get you to update the MockUnhealthyWorkspace entity a little more for me? I think it's a bit more "realistic" if the agent is actually in an error state, as that affects some other styling on the page. I came up with...
export const MockUnhealthyWorkspace: TypesGen.Workspace = {
...MockWorkspace,
id: "test-unhealthy-workspace",
health: {
healthy: false,
failing_agents: [MockWorkspaceAgent.id],
},
latest_build: {
...MockWorkspace.latest_build,
resources: [
{
...MockWorkspaceResource,
agents: [
{
...MockWorkspaceAgent,
status: "timeout",
lifecycle_state: "start_error",
health: { healthy: false },
},
],
},
],
},
};it might even be worth splitting into a MockUnhealthyAgent if you want but I'll leave it up to you
| @@ -192,6 +196,41 @@ export const Workspace: FC<WorkspaceProps> = ({ | |||
| </Alert> | |||
| )} | |||
|
|
|||
| {!workspace.health.healthy && ( | |||
| <Alert severity="warning"> | |||
There was a problem hiding this comment.
the existing popup has the same problem. it should definitely get fixed eventually but our colors are a bit of a mess right now. probably out of scope for this issue.
Good idea. These stories make a lot more visual sense now that the agent is red instead of blue 
|
closes #19338