Skip to content

chore(scaletest): add tls to infrastructure #19412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

chore(scaletest): add tls to infrastructure #19412

merged 1 commit into from
Aug 25, 2025
+270 −133

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 19, 2025 •
edited
Loading

Closes coder/internal#850

This PR has the scaletest infrastructure retrieve and use TLS certificates from the persistent observability cluster.

To support creating multiple instances of the infrastructure simultaneously, var.name can be set to alpha, bravo or charlie, which retrieves the corresponding certificates.

Also:

  • Adds support for wildcard apps.
  • Retrieves the Cloudflare token from GCP secrets.

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Aug 19, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review August 19, 2025 14:25
deansheather
deansheather reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are nitpicks but LGTM. Deferring to Spike for approval since I contributed

@ethanndickson ethanndickson changed the title feat: add tls to scaletest infrastructure chore: add tls to scaletest infrastructure Aug 20, 2025
This was referenced Aug 21, 2025
Open
Merged
@ethanndickson ethanndickson mentioned this pull request Aug 22, 2025
Open
@ethanndickson ethanndickson changed the title chore: add tls to scaletest infrastructure chore(scaletest): add tls to infrastructure Aug 22, 2025
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Aug 25, 2025 •
edited
Loading

Merge activity

  • Aug 25, 2:24 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 25, 2:25 AM UTC: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 5145cd0 into main Aug 25, 2025
32 of 33 checks passed
@ethanndickson ethanndickson deleted the ethan/tls-scaletest branch August 25, 2025 02:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather left review comments

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TLS to Coder control plane and proxies in scale test
3 participants
@ethanndickson @spikecurtis @deansheather
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy