Skip to content

feat: show workspace build logs during tasks creation #19413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BrunoQuaresma
Copy link
Collaborator

This is part of #19363

Screenshot:
Screenshot 2025-08-19 at 12 32 54

Video demo:

Screen.Recording.2025-08-19.at.12.32.15.mov

@BrunoQuaresma BrunoQuaresma requested review from johnstcn and a team August 19, 2025 15:35
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 19, 2025
@BrunoQuaresma BrunoQuaresma removed the request for review from a team August 19, 2025 15:35
@BrunoQuaresma BrunoQuaresma requested a review from aslilac as a code owner August 19, 2025 15:35
@BrunoQuaresma BrunoQuaresma changed the title feat: shows workspace build logs during tasks creation feat: show workspace build logs during tasks creation Aug 19, 2025
@matifali
Copy link
Member

Should we collapse/hide these by default and only show if a user clicks on show build logs?

I think for most Tasks users they may not be interested in seeing the build logs.

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some stories for the following scenarios:

  • Workspace build pending
  • Workspace build running
  • Workspace build failed

@BrunoQuaresma
Copy link
Collaborator Author

@matifali I would agree with you if the screen had more info. Display the build logs is a way to show to the user that things are in progress. Before make any changes to it, I would like to test this hypothesis and see what users think about that, wdyt?

@BrunoQuaresma
Copy link
Collaborator Author

@johnstcn they are already there.

@BrunoQuaresma BrunoQuaresma requested a review from johnstcn August 19, 2025 16:01
@matifali
Copy link
Member

@BrunoQuaresma, I am fine if we want to test this. What I was thinking is a loading animation of some kind (Spinner) and a button to view logs if needed.

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed seeing the stories! UI changes LGTM but also need approval from FE domain expert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy