Skip to content

site: fix GFM alerts rendering when links are present #19422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blink-so[bot]
Copy link
Contributor

@blink-so blink-so bot commented Aug 19, 2025

Fixes #19409

Fixes a rendering bug where GFM alerts (e.g., NOTE/TIP/IMPORTANT) lost content when links were present.

Changes:

  • Update Markdown alert parsing to include sibling nodes after the alert header paragraph so all alert content renders
  • Ensure links inside alerts open in a new tab and include screen-reader hint

Testing:

  • Storybook CI build for Markdown stories; GFM alerts render correctly with links
  • Site tests: 640 passed locally

No server changes.

blink-so bot added 2 commits August 19, 2025 17:36
…railing content renders inside the alert by including sibling nodes after the header paragraph. Adds target=_blank and sr-only text for links inside alerts.\n\nCo-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: GFM alerts not displaying properly when links are present
0 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy