Skip to content

fix: support oidc group allowlist in oss #19430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix: support oidc group allowlist in oss #19430

merged 1 commit into from
Aug 20, 2025

Conversation

rafrdz
Copy link
Contributor

@rafrdz rafrdz commented Aug 19, 2025 •
edited
Loading

Summary

In this pull request we're adding support for OIDC allowed groups in the OSS version as part of work for #17027.

Changes

  • Restored support for parsing group allow list in OSS code

Testing

  • Added tests for OSS code
  • Tested allowed/prohibited group OIDC flows in premium and OSS

@rafrdz rafrdz requested a review from Emyrk August 19, 2025 21:06
Emyrk
Emyrk approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stirby worth a callout in the release notes.

CODER_OIDC_ALLOWED_GROUPS is back to an OSS feature

@rafrdz rafrdz mentioned this pull request Aug 20, 2025
Open
1 task
@rafrdz rafrdz merged commit 5b1e809 into main Aug 20, 2025
35 checks passed
@rafrdz rafrdz deleted the rafrdz/allow-groups-oss branch August 20, 2025 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@rafrdz rafrdz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafrdz @Emyrk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy