fix: add database constraint to enforce minimum username length #19453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
length and regex are already enforced at the application layer, but we have some code paths with database queries where we could optimize away many of the DB query calls if we could be sure at the database level that the username is never an empty string. Signed-off-by: Callum Styan <callumstyan@gmail.com>
The failing tests are actually catching this! |
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
dannykopping
approved these changes
Aug 21, 2025
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE users | |||
| ADD CONSTRAINT users_username_min_length | |||
| CHECK (length(username) >= 1); | |||
There was a problem hiding this comment.
I wonder if we should expand this constraint to take the other clauses into account:
https://github.com/coder/coder/blob/main/codersdk/name.go#L41-L60
In any case, enforcing the minimum solves our immediate problem so I'm approving, but we might be overfitting.
There was a problem hiding this comment.
I don't think we need to duplicate the entire logic here.
There was a problem hiding this comment.
I'm not advocating for duplicating so much as replacing the logic; should've been more explicit.
johnstcn
approved these changes
Aug 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Username length and format, via regex, are already enforced at the application layer, but we have some code paths with database queries where we could optimize away many of the DB query calls if we could be sure at the database level that the username is never an empty string.
For example: #19395