fix: limit test parallelism in make test
#19465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test
Signed-off-by: Spike Curtis <spike@coder.com>
393f91c to
cb78863
Compare
johnstcn
approved these changes
Aug 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get
make testto reliably pass again on our dogfood workspaces, we're having to resort to setting parallelism.It also reworks our CI to call the
make testtarget, instead of rolling a different command.Behavior changes:
make test-shortflag. In my testing it makes only a few seconds difference on ~200s, or 1-2%-count=1flag that busts Go's test cache. With a fresh cache and no code changes,make testexecutes in ~15 seconds.