fix: ws schedule as 12-hour format #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
commented
Jun 9, 2022
johnstcn
approved these changes
Jun 9, 2022
Kira-Pilot
approved these changes
Jun 9, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
This does not finish all tasks in #2175 but is one of the asks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not finish all tasks in #2175 but is one of the asks.
@johnstcn - you should do the same lowercasing of HH->hh in #2165
The 24-hour format looks strange with AM/PM.
See here to verify:
https://day.js.org/docs/en/display/format#list-of-all-available-formats