Skip to content

fix: Use WebSockets to stream workspace build logs #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2022
Merged

fix: Use WebSockets to stream workspace build logs #2569

merged 6 commits into from
Jun 22, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 22, 2022 •
edited by misskniss
Loading

This was using a streaming HTTP request before, which didn't work
on my version of Chrome. This method seemed less reliable and standard
than a WebSocket, so figured switching would be best.

Fixes #2570

@kylecarbs
fix: Use WebSockets to stream workspace build logs
1c49916 
This was using a streaming HTTP request before, which didn't work
on my version of Chrome. This method seemed less reliable and standard
than a WebSocket, so figured switching would be best.
@kylecarbs kylecarbs requested a review from AbhineetJain June 22, 2022 03:31
@kylecarbs kylecarbs requested a review from a team as a code owner June 22, 2022 03:31
@kylecarbs kylecarbs self-assigned this Jun 22, 2022
AbhineetJain
AbhineetJain approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Some minor comments.

kylecarbs and others added 3 commits June 22, 2022 08:02
@kylecarbs @AbhineetJain
Update site/src/xServices/workspaceBuild/workspaceBuildXService.ts
700b591 
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
@kylecarbs @AbhineetJain
Update site/src/pages/WorkspaceBuildPage/WorkspaceBuildPage.test.tsx
f46d188 
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
@kylecarbs @AbhineetJain
Update site/src/api/api.ts
23134e4 
Co-authored-by: Abhineet Jain <AbhineetJain@users.noreply.github.com>
@kylecarbs kylecarbs enabled auto-merge (squash) June 22, 2022 13:12
@kylecarbs kylecarbs merged commit 1778db2 into main Jun 22, 2022
@kylecarbs kylecarbs deleted the wslogs branch June 22, 2022 13:23
@kylecarbs kylecarbs mentioned this pull request Jun 22, 2022
Closed
@tjcran tjcran mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

+1 more reviewer

@AbhineetJain AbhineetJain AbhineetJain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

templates with parameter cannot be updated
3 participants
@kylecarbs @AbhineetJain @Kira-Pilot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy