added a default app icon #2595
Merged
added a default app icon #2595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #2268
AbhineetJain
approved these changes
Jun 22, 2022
I already created a PR for this #2591 :) |
|
@ntimo that's awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2268
Added a default icon for apps without icons. I figured this should be the same as terminal - we don't need to clog up our page with a bunch of icons yet - but let me know if you feel differently.
There was actually already a story for this case, as you see if you look at Chromatic.
NOTE: I would love to add the appropriate code-server icon to the app as mentioned in the ticket, but I'm unsure where to do this. If someone points me in the right direction, I will def update.