feat: show template versions #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AbhineetJain merged 2 commits into main from abhineetjain/2876-show-template-versions

Jul 15, 2022

Contributor

AbhineetJain commented Jul 15, 2022

This PR shows the template versions in a table on the Template Versions page.

This PR is dependent on #3001.

Subtasks

add a component to show the template versions in a table
make an API call to fetch template versions
add stories
update unit test

Screenshot

Fixes #2876

AbhineetJain requested a review from a team as a code owner

July 15, 2022 01:38

Kira-Pilot reviewed

View reviewed changes

site/src/components/VersionsTable/VersionsTable.stories.tsx Show resolved Hide resolved

Kira-Pilot reviewed

View reviewed changes

site/src/components/VersionsTable/VersionsTable.tsx Show resolved Hide resolved

Kira-Pilot reviewed

View reviewed changes

site/src/components/VersionsTable/VersionsTable.tsx Outdated Show resolved Hide resolved

Kira-Pilot reviewed

View reviewed changes

site/src/components/VersionsTable/VersionsTable.tsx Show resolved Hide resolved

Kira-Pilot reviewed

View reviewed changes

site/src/pages/TemplatePage/TemplatePage.tsx Outdated Show resolved Hide resolved

Kira-Pilot reviewed

View reviewed changes

Member

Kira-Pilot left a comment

This looks great! Nice work!

Kira-Pilot approved these changes

View reviewed changes

Base automatically changed from abhineetjain/2876-add-template-version-creator to main

July 15, 2022 21:12

AbhineetJain added 2 commits

July 15, 2022 21:35


          feat: show template versions

d53827e


          update isLoading logic and remove hover

9fde35d

AbhineetJain force-pushed the abhineetjain/2876-show-template-versions branch from a60bb89 to 9fde35d Compare

July 15, 2022 21:36

AbhineetJain merged commit ccdf82d into main

AbhineetJain deleted the abhineetjain/2876-show-template-versions branch

July 15, 2022 22:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy