Skip to content

fix: chromatic workflow filter #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR fixes the workflow filter for checking when to run the Chromatic job. Currently, the Chromatic job is being skipped even for TypeScript changes.

@AbhineetJain AbhineetJain requested a review from ammario August 2, 2022 05:55
@AbhineetJain
Copy link
Contributor Author

AbhineetJain commented Aug 2, 2022

Merged this branch into #3341 and #3346 to confirm that the change works.

@AbhineetJain AbhineetJain requested a review from a team August 2, 2022 05:58
@AbhineetJain AbhineetJain merged commit 5ae19f0 into main Aug 2, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/fix-chromatic-workflow branch August 2, 2022 08:23
@Kira-Pilot
Copy link
Member

Late to the game, but thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy